Set wsgi.url_scheme with HTTP_X_SCHEME header

[delijati]

Set wsgi.url_scheme with HTTP_X_SCHEME header

[posativ]

Thanks, but can you tell what kind of bugs this fixes?

[lugensa]

im using nginx and https. without that fix the only way to get scheme https added is to set --base_url

[delijati]

uh sorry "lugensa" is my working account ...

[posativ]

Okay, sounds good (use the --base_url flag). I'll release a new version on PyPi including this fix.

[lkraav]

Guys, this commit 9f4f817 is broken.

I'm running weave-minimal behind apache SSL proxypass, with --base-url="https://server/sync/".

I think the protocol cannot be decided only using the header specified in the commit. In my case, base-url should definitely be added as a factor.

Right now I'm working around it by just adding "https" there as a default.

Thoughts?

[lkraav]

I think this is solved with a documentation patch. See PR.

[posativ]

Hi @delijati, I replaced X-Scheme with X-Forwarded-Proto because the latter is the de-facto standard identifier (via https://en.wikipedia.org/wiki/List_of_HTTP_header_fields).