Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch bootstrap token to a random_password #251

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Conversation

dghubble
Copy link
Member

@dghubble dghubble commented Mar 14, 2021

  • Terraform random_password is identical to random_string except its value is marked sensitive so it isn't displayed in terraform plan and other outputs
  • Prefer marking the bootstrap token as sensitive for cases where terraform is run in an automated CI/CD system

Rel: https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password

* Terraform `random_password` is identical to `random_string` except
its value is marked sensitive so it isn't displayed in terraform
plan and other outputs
* Prefer marking the bootstrap token as sensitive for cases where
terraform is run in an automated CI/CD system
@dghubble dghubble merged commit 8fc689b into master Mar 14, 2021
@dghubble dghubble deleted the sensitive-token branch March 14, 2021 18:24
dghubble added a commit to poseidon/typhoon that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
dghubble-robot pushed a commit to poseidon/terraform-onprem-kubernetes that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
dghubble-robot pushed a commit to poseidon/terraform-google-kubernetes that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
dghubble-robot pushed a commit to poseidon/terraform-azure-kubernetes that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
dghubble-robot pushed a commit to poseidon/terraform-aws-kubernetes that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
dghubble-robot pushed a commit to poseidon/terraform-digitalocean-kubernetes that referenced this pull request Mar 14, 2021
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
Snaipe pushed a commit to aristanetworks/monsoon that referenced this pull request Apr 13, 2023
* Mark the bootstrap token as sensitive, which is useful when
Terraform is run in automated CI/CD systems to avoid showing
the token
* poseidon/terraform-render-bootstrap#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant