Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Server Addon #368

Closed
deltasquare4 opened this issue Dec 25, 2018 · 6 comments
Closed

Metrics Server Addon #368

deltasquare4 opened this issue Dec 25, 2018 · 6 comments

Comments

@deltasquare4
Copy link

Feature Request

Feature

Replace Heapster addon with metrics-server.

Tradeoffs

Heapster is deprecated, and Typhoon has already decided to replace it with metrics-server addon. I have been trying to do it with the intention to contribute back the addon to Typhoon. The problem is, metrics-server seems to require --requestheader-client-ca-file flag on the apiserver, which Typhoon doesn't allow as commented in #338.

@dghubble Can you please outline how metrics-server aggregated API can authenticate without adding support for authenticating proxy?

@dghubble
Copy link
Member

dghubble commented Jan 1, 2019

I evaluated metrics server back in May. It requires the aggregation API and I still have concerns around that. Fast forward a few months and the aggregation server was at the root of CVE-2018-1002105.

Aggregation APIs' complexity and attack surface just don't seem worth it for addons like metrics server, its a "nice to have" addon that makes kubectl top work. Meanwhile, the provide heapster addon works fine and has no such aggregation requirement.

If the metrics server addon or aggregation becomes compelling to me, I'll add them then, but its not on my roadmap atm.

@dghubble dghubble closed this as completed Jan 1, 2019
@mabushey
Copy link

How can you do autoscaling w/o metrics server? Heapster is dead.

@jmreicha
Copy link
Contributor

jmreicha commented Jan 23, 2019

Heapster is deprecated in k8s 1.13.

Users are encouraged to use metrics-server instead, potentially supplemented by a third-party monitoring solution, such as Prometheus.

@mabushey
Copy link

@jmreicha That's exactly my point. Typhoon only supports heapster, NOT metrics-server.

@jmreicha
Copy link
Contributor

@mabushey I agree with you, I would also like to see support for metrics-server added 😁

@mabushey
Copy link

@dghubble The 0.3.x versions of Metrics Server are now using Webhook for it's authorizationMode, so some of what you looked at before has probably changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants