Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the html() helper works #14

Closed
rich-iannone opened this issue Oct 13, 2023 · 1 comment
Closed

Ensure that the html() helper works #14

rich-iannone opened this issue Oct 13, 2023 · 1 comment

Comments

@rich-iannone
Copy link
Member

Similar to #13, we need to make the html() work with tab_header() (and other functions where new labels are accepted, eventually). Example:

import gt
from gt import exibble, countrypops, gtcars, md, html

from siuba import *

res = gtcars >> select(_.mfr, _.model, _.msrp) >> _.head(5)

gt.GT(res).tab_header(
    title=html("Data listing from <strong>gtcars</strong>"),
    subtitle=html("From <span style='color:red;'>gtcars</span>"),
)
@rich-iannone rich-iannone self-assigned this Oct 13, 2023
@rich-iannone rich-iannone changed the title Ensure that html() helper works Ensure that the html() helper works Nov 7, 2023
@rich-iannone rich-iannone added this to the v0.1.0 milestone Nov 9, 2023
@rich-iannone
Copy link
Member Author

This is now implemented in a recent commit. And it’s now required if you want to use HTML strings since input text is now HTML-escaped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant