Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat selectors #107

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Feat selectors #107

merged 7 commits into from
Jan 5, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented Jan 5, 2024 •
edited

This PR addresses #102 by...

  • allowing functions for row selection in fmt_* methods
  • allowing functions for row selection in body.* functions.
  • It also allows polars selectors (and anything used by resolve_rows_i) in fmt_* methods

TODO:

  • Add simple tests using fmt(), and CellStyle._evaluate_expressions()

@github-actions github-actions bot temporarily deployed to pr-107 January 5, 2024 21:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-107 January 5, 2024 21:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-107 January 5, 2024 22:00 Destroyed
@machow machow marked this pull request as ready for review January 5, 2024 22:06
rich-iannone
rich-iannone approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit eb24086 into main Jan 5, 2024
6 checks passed
@rich-iannone rich-iannone deleted the feat-selectors branch January 5, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@machow @rich-iannone