Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validate frame #118

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Fix validate frame #118

merged 4 commits into from
Jan 13, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented Jan 12, 2024

Addresses #117 by giving a hopefully diagnostic error message, when a pandas DataFrame with duplicate column names is passed: Column names must be unique. Detected duplicate columns:\n\n <specific list>

TODO: we should also fail DataFrames with multi-index columns. (done!)

Fixes: #117

@github-actions github-actions bot temporarily deployed to pr-118 January 12, 2024 18:38 Destroyed
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit bd88d1a into main Jan 13, 2024
6 checks passed
@rich-iannone rich-iannone deleted the fix-validate-frame branch February 13, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give better error message when pandas DataFrame has duplicate column names
2 participants