Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use to_list() method as cross-df solution #128

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

rich-iannone
Copy link
Member

This corrects the problem with Polars DataFrames not working with the data_color() method due to the problem of using Pandas' tolist() instead of our own to_list() method (which works with both).

@github-actions github-actions bot temporarily deployed to pr-128 January 23, 2024 18:10 Destroyed
@github-actions github-actions bot temporarily deployed to pr-128 January 23, 2024 19:02 Destroyed
@github-actions github-actions bot temporarily deployed to pr-128 January 23, 2024 19:23 Destroyed
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit d045799 into main Jan 23, 2024
7 checks passed
@rich-iannone rich-iannone deleted the data-color-polars-fix branch January 23, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants