Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed to support PEP-561 (type-hinting) #139

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

sugatoray
Copy link
Contributor

@sugatoray sugatoray commented Jan 30, 2024

Summary

This adds support for type-hinting information as laid in PEP-561.

Closes #141

Checklist

@machow machow self-requested a review January 30, 2024 14:23
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! @rich-iannone if this looks okay, do you want to merge?

@sugatoray sugatoray changed the title Add py.typed to support PEP-561 Add py.typed to support PEP-561 (type-hinting) Jan 30, 2024
@machow
Copy link
Collaborator

machow commented Jan 30, 2024

(note that docs deploy always fail for PRs from other repos, so this LGTM!)

@rich-iannone
Copy link
Member

LGTM!

@rich-iannone rich-iannone merged commit fb1ecf8 into posit-dev:main Jan 30, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PEP-561: type-hinting [great-tables]
3 participants