Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs examples sports #195

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Docs examples sports #195

merged 5 commits into from
Feb 14, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented Feb 14, 2024

This PR adds a new example, showing off fmt_image and an html barplot based on this cool tweet.

Note that I added it as a ipynb. I'm not sure if this is better than just a qmd, but wonder if it might be a nice lil touch for the notebook crowd.

Currently the link in examples points to this branch in the gh repo. Once the PR looks good--I'll change it to main.

@github-actions github-actions bot temporarily deployed to pr-195 February 14, 2024 18:41 Destroyed
@machow machow marked this pull request as ready for review February 14, 2024 18:43
@machow
Copy link
Collaborator Author

machow commented Feb 14, 2024

The examples section could use some sprucing up down the road, but here's what the example looks like:

image

@github-actions github-actions bot temporarily deployed to pr-195 February 14, 2024 18:49 Destroyed
@rich-iannone rich-iannone self-requested a review February 14, 2024 19:19
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent. Please merge ASAP!!!

@machow machow merged commit 82455e5 into main Feb 14, 2024
7 checks passed
@rich-iannone rich-iannone deleted the docs-examples-sports branch February 14, 2024 21:33
@jrycw
Copy link
Contributor

jrycw commented Feb 15, 2024

It looks fantastic!🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants