Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the opt_stylize() method #198

Merged
merged 14 commits into from
Feb 21, 2024
Merged

Add the opt_stylize() method #198

merged 14 commits into from
Feb 21, 2024

Conversation

rich-iannone
Copy link
Member

This adds in the opt_stylize() method. With it you can quickly style a table with a carefully curated set of background colors, line colors, and line styles. There are six styles to choose from and they largely vary in the extent of coloring applied to different table locations. Some have table borders applied, some apply darker colors to the table stub and summary sections, and, some even have vertical lines. In addition to choosing a style preset, there are six color variations that each use a range of five color tints. Each of the color tints have been fine-tuned to maximize the contrast between text and its background. There are 36 combinations of style and color to choose from.

Fixes: #165

@github-actions github-actions bot temporarily deployed to pr-198 February 19, 2024 22:14 Destroyed
@rich-iannone rich-iannone marked this pull request as ready for review February 20, 2024 14:51
@github-actions github-actions bot temporarily deployed to pr-198 February 20, 2024 16:00 Destroyed
@machow machow self-requested a review February 21, 2024 15:37
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion on potentially creating a class to do the mapping, but feel free to merge and just create an issue if we want to punt!

great_tables/_options.py Outdated Show resolved Hide resolved
great_tables/_options.py Show resolved Hide resolved
great_tables/_options.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-198 February 21, 2024 21:07 Destroyed
@github-actions github-actions bot temporarily deployed to pr-198 February 21, 2024 21:09 Destroyed
@rich-iannone rich-iannone merged commit 136a31e into main Feb 21, 2024
7 checks passed
@rich-iannone rich-iannone deleted the opt-stylize branch February 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epic: Implement table themes
2 participants