Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of supported Python versions to match those tested #269

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

discdiver
Copy link
Contributor

@discdiver discdiver commented Apr 5, 2024

Summary

Existing README screenshot:
Screenshot 2024-04-05 at 8 40 52 AM

Shows support for Python 3.7, 3.8, and 3.9. The GitHub Actions test matrix shows python-version: ["3.9", "3.10", "3.11", "3.12"].

This PR updates the supported Python version list to match what's tested.

Checklist

  • I understand and agree to the Code of Conduct.
  • [n/a] I have followed the Style Guide for Python Code as best as possible for the submitted code.
  • [n/a] I have added pytest unit tests for any new functionality.

Fixes: #220

@rich-iannone rich-iannone requested a review from machow April 5, 2024 13:04
@discdiver
Copy link
Contributor Author

Not sure why pre-commit failed - I didn't touch the file it changed.

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--thanks for taking the time to fix this up! I went ahead and pushed the black formatting to this PR. I'm a bit stumped on what happened, but am guessing that black maybe conditions some formatting rules on required python or something? (Or pre-commit did something based on required python?)

@rich-iannone rich-iannone merged commit d4178e0 into posit-dev:main Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

great-tables==0.3.1 is not compatible with python 3.7 because of htmltools>=0.4.1 is required
3 participants