-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue with table_font_color
not accepting named colors
#285
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 81.71% 81.71%
=======================================
Files 41 41
Lines 4325 4327 +2
=======================================
+ Hits 3534 3536 +2
Misses 791 791 ☔ View full report in Codecov by Sentry. |
table_font_color
not accepting named Colorstable_font_color
not accepting named colors
Thanks so much for this work! I'm pairing right now with @rich-iannone, and he mentioned this function should always return hex (which it wasn't even before this PR). I've tweaked it a bit, so that when things like "transparent" are passed, hex colors are output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM--thanks for catching this issue
The refactored code looks better. In fact, the variable names definitely represent their meaning clearly. |
It appears we're having an issue with the Table Theme Options -> Set options across table parts section.
The problem seems to arise when color values are input using common names like
yellow
orwhite
, causing thefont_color
not to transform them into the appropriate hexadecimal format.To address this issue, I've implemented a conversion pattern similar to the one used in
font_color
, which should hopefully resolve the issue.Additionally, I noticed quick returns in the first few lines of
font_color
. I'm uncertain whether these also need conversion. Could the team please review this aspect?