Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #311

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Improve test coverage #311

merged 2 commits into from
Apr 22, 2024

Conversation

jrycw
Copy link
Contributor

@jrycw jrycw commented Apr 21, 2024

This PR aims to enhance the test coverage.

Improve test coverage
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.36%. Comparing base (14ce2c5) to head (de7cfb7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   81.71%   82.36%   +0.64%     
==========================================
  Files          41       41              
  Lines        4321     4321              
==========================================
+ Hits         3531     3559      +28     
+ Misses        790      762      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Covers a bunch of important little cases and this helps a lot with our coverage efforts.

@machow machow merged commit b9ad5e0 into posit-dev:main Apr 22, 2024
9 checks passed
@jrycw jrycw deleted the add-tests branch April 22, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants