Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt_image erroring on missing values #329

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix fmt_image erroring on missing values #329

merged 2 commits into from
May 7, 2024

Conversation

machow
Copy link
Collaborator

@machow machow commented May 7, 2024

This PR fixes a bug, where fmt_image errored on missing values.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.44%. Comparing base (435c8ad) to head (f3c2b6f).

Files Patch % Lines
great_tables/_formats.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   83.43%   83.44%   +0.01%     
==========================================
  Files          41       41              
  Lines        4287     4290       +3     
==========================================
+ Hits         3577     3580       +3     
  Misses        710      710              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit d6ad973 into main May 7, 2024
9 checks passed
@rich-iannone rich-iannone deleted the fix-misc-pycon branch May 7, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants