Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance column selection to support Polars expressions #346

Closed
wants to merge 2 commits into from

Conversation

jrycw
Copy link
Contributor

@jrycw jrycw commented May 15, 2024

Related to #340.

This PR aims to extend column selection to support Polars expressions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.51%. Comparing base (7eae1f2) to head (25774f2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   83.51%   83.51%           
=======================================
  Files          41       41           
  Lines        4308     4308           
=======================================
  Hits         3598     3598           
  Misses        710      710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator

machow commented May 15, 2024

Thanks for taking the time to implement this---I left some thoughts in the comments. I'm open to this, but trying to get a feel for where the selection API is going? (suspecting it might not change too much?). If it's okay with you, let's wait a bit and collect more info on the pl.col() vs selector situation.

@jrycw
Copy link
Contributor Author

jrycw commented May 15, 2024

@machow , thank you for your response. Let's hold off for now and see how things progress. I'll mark this PR as a draft for the time being. On another note, it appears that our project is gaining more attention from the community. I suggest that we tidy up the finished issues before the next minor release (0.6.0). This way, future contributors can easily identify and tackle the issues they want to help with.

@jrycw jrycw marked this pull request as draft May 15, 2024 15:21
@jrycw
Copy link
Contributor Author

jrycw commented May 24, 2024

I'll close this PR since the column selection of Polars is being refactored through #360 and is included in version 0.6.1.

@jrycw jrycw closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants