Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add example coffee table with nanoplots #349

Merged
merged 5 commits into from
May 15, 2024
Merged

Conversation

machow
Copy link
Collaborator

@machow machow commented May 15, 2024

This PR adds the coffee table example from https://github.com/machow/coffee-sales-data/

Note these extra code pieces:

  • tiny fix: remove two spaces in the base64 encoding in <img> tags. Necessary for displaying in jupyter notebooks on github. E.g.
    • old: <img src="data: image/png...
    • new: <img src="data:image/png...
  • chore: remove polars map_elements warning by specifying output type

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (d0fe061) to head (7308ea4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          41       41           
  Lines        4346     4346           
=======================================
  Hits         3682     3682           
  Misses        664      664           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit b575b6e into main May 15, 2024
11 checks passed
@rich-iannone rich-iannone deleted the docs-example-coffee branch May 24, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants