Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with _save_screenshot() #352

Merged
merged 3 commits into from
May 23, 2024
Merged

fix: issue with _save_screenshot() #352

merged 3 commits into from
May 23, 2024

Conversation

jrycw
Copy link
Contributor

@jrycw jrycw commented May 17, 2024

It seems that we need to use f.read() to avoid the TypeError: a bytes-like object is required, not '_io.BufferedReader'.

@jrycw jrycw changed the title fix: issue with screenshot fix: issue with _save_screenshot() May 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (6b2624b) to head (c0ea247).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   85.74%   85.90%   +0.16%     
==========================================
  Files          41       41              
  Lines        4328     4328              
==========================================
+ Hits         3711     3718       +7     
+ Misses        617      610       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machow
Copy link
Collaborator

machow commented May 23, 2024

Merged in main so we could re-run tests

Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching---hope it's okay I chucked in a quick test (which I should have included in the original PR 😓 ). I double checked a pdf output for sanity and it looked good

@machow machow merged commit e3649d2 into posit-dev:main May 23, 2024
11 checks passed
@jrycw jrycw deleted the fix-save branch May 24, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants