-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dedicated RStudio keymap #2067
Conversation
Another way to do this might be to have the extension activate on a command. That would be a little more complicated to implement (a setting in a different extension might have to run the command? dynamically loading it at startup when enabled might be harder?), but it would make things cleaner from a user perspective -- right now you always see the RStudio Keymap items in the Keyboard Shortcuts dialog (with the config flag); if we enabled on a command then you'd only see them if the keymap was actually turned on. |
I just tried this (e1552bc) and it doesn't work the way I thought. It appears based on my testing that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
This change adds an RStudio keymap to Positron, and implements all of the keybindings that have been specifically requested by alpha users. Namely:
There are a lot more keybindings we'll probably end up adding, but these seem to be causing the most friction.
Note that most of the bindings mentioned in #669 are already implemented in the R extension; we felt it was okay to take most of these bindings when the user is editing an R package.
The keymaps are implemented in a new extension which is currently codeless, but will probably have code later so we can add custom RStudio-like logic for other keys/commands. As there is no way to see or disable built-in or bundled extensions, we gate all the extension's bindings on a setting that can be toggled here:
Turning on this setting activates the keybindings (no restart necessary!).
Addresses #669.