-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme fixes #68
Theme fixes #68
Conversation
I also lowered the font weight for the site to 300. 400 seems too heavy for the amount of content that we have. However, I left it at 400 for dark mode.
… font weight because that was flagged as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕶️
@@ -93,6 +98,56 @@ $body-bg: $dark-md-background !default; // dark mode change | |||
background-color: #0f1c29 !important; | |||
} | |||
|
|||
/* Search results */ | |||
|
|||
.aa-DetachedOverlay .aa-SourceHeader .search-result-header, #quarto-search-results .aa-SourceHeader .search-result-header { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that we need to style such specific things. I would have expected Quarto to make this type of adjustment smoother through variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that we just had a quick slack chat but yeah - the colors are inherited by variables that we have set. Our dark theme $primary
color is $primary: $posit-teal;
and the "background" of the search was showing that teal...which was terrible.
So the colors that search is using are all set with variables however, there isn't a clean way to override those things without having to dig into this gross CSS to do so.
I looked through bootstrap and I didn't see any type of search results/box customization nor did I in Quarto :(
Resolves #67
Resolves #66
Resolves #64
tested search window using Lighthouse > Snapshot
Resolves #63