feat(card): Report full screen state as a Shiny input #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Mar 13, 2024
| @@ -20,6 +20,7 @@ ignore <- capture.output({ | |||
| pak::pkg_install(c( | |||
| "rstudio/bslib@main", | |||
| "rstudio/shiny@main", | |||
| "rstudio/sass@main", | |||
There was a problem hiding this comment.
Just curious, is this needed for this PR? Or just a good idea to do this in general?
There was a problem hiding this comment.
I just wanted to make sure we were getting the right fonts since we do some theme re-compilation. I don't think it actually changed any of the files, though so we could take it out. (Or leave it in until the next sass version is released, idk)
There was a problem hiding this comment.
I'm going to leave this in for now. Installing sass takes long enough that I'm sure we won't forget to revisit it 😉
|
For posterity, this PR also pulls in rstudio/bslib#1004 which is why the |
cpsievert
approved these changes
Mar 13, 2024
schloerke
added a commit
that referenced
this pull request
Mar 15, 2024
* main: Add support for Shiny Express in Quarto Dashboards, take 2 (#1217) Force UTF-8 for Shiny Express on Windows (#1203) Typing fixes feat(card): Report full screen state as a Shiny input (#1215) Use TypeScript strict mode (#1208) Update author email test: Resolve testing comments (#1206) Fix URL Update badges Bump dev version to 0.8.1.9000 (#1202) chore(deps): Update bslib css (#1200) chore: no new features v0.8.1
schloerke
added a commit
to joesho112358/py-shiny
that referenced
this pull request
Mar 23, 2024
* main: (24 commits) chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241) Add back missing session methods (posit-dev#1239) Add kitchensink tests for valuebox (posit-dev#1229) For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233) feat: Editable data frame (posit-dev#1198) Add tests for shiny_mode comment detection fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207) chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086) chore: use dev htmtlools (posit-dev#1228) feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222) feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223) fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219) Update bslib and shiny dependencies (posit-dev#1221) Update docstring and give hint for mypy Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217) Force UTF-8 for Shiny Express on Windows (posit-dev#1203) Typing fixes feat(card): Report full screen state as a Shiny input (posit-dev#1215) Use TypeScript strict mode (posit-dev#1208) Update author email ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with rstudio/bslib#1006
ui.card()andui.value_box()gain anidargument and report their state at the input id, if provided by the user.full_screenstate is currently reported, but the state value is a dictionary for future expansion.Todo