feat(layout_columns): Use sm as the default col_widths breakpoint
#1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
approved these changes
Mar 18, 2024
schloerke
added a commit
to joesho112358/py-shiny
that referenced
this pull request
Mar 23, 2024
* main: (24 commits) chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241) Add back missing session methods (posit-dev#1239) Add kitchensink tests for valuebox (posit-dev#1229) For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233) feat: Editable data frame (posit-dev#1198) Add tests for shiny_mode comment detection fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207) chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086) chore: use dev htmtlools (posit-dev#1228) feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222) feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223) fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219) Update bslib and shiny dependencies (posit-dev#1221) Update docstring and give hint for mypy Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217) Force UTF-8 for Shiny Express on Windows (posit-dev#1203) Typing fixes feat(card): Report full screen state as a Shiny input (posit-dev#1215) Use TypeScript strict mode (posit-dev#1208) Update author email ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to rstudio/bslib#1014
col_widths=(12, 6, 6)now becomescol_widths={"sm": (12, 6, 6)}where we previously usedmdas the default breakpoint. This update aligns with the intuitive expectation thatcol_widthsof a single value is the column widths at all breakpoints (except mobile where we do something completely different).While here I noticed that we actually do need to include the
xs-specific class that activates its corresponding CSS variable. Without this change,row_heights={"xs": ...}doesn't work as expected.Todo
smas the defaultcol_widthsbreakpoint rstudio/bslib#1014