Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(conftest): Refactor conftest and controls to be imported as shiny.test module #1413

Merged
merged 17 commits into from
May 30, 2024

Conversation

karangattu
Copy link
Collaborator

@karangattu karangattu commented May 23, 2024

Related: #1281

This will help address #1156 since it abstracts the fixtures needed to start a shiny app locally before the test runs as well as controls that expose helper functions for different components users could use to test their shiny dashboards/apps.

@karangattu karangattu changed the title test(conftests): Refactor conftest functions to be imported as shiny.test module test(conftest): Refactor conftest and controls to be imported as shiny.test module May 28, 2024
@karangattu karangattu marked this pull request as ready for review May 28, 2024 18:40
@karangattu karangattu requested a review from schloerke May 28, 2024 18:40
shiny/test/__init__.py Show resolved Hide resolved
shiny/test/_conftest.py Outdated Show resolved Hide resolved
shiny/test/_conftest.py Show resolved Hide resolved
shiny/test/_conftest.py Outdated Show resolved Hide resolved
shiny/test/_conftest.py Show resolved Hide resolved
shiny/test/_pytest.py Outdated Show resolved Hide resolved
shiny/test/_pytest.py Show resolved Hide resolved
shiny/test/fixture/_fixture.py Outdated Show resolved Hide resolved
shiny/test/fixture/_fixture.py Show resolved Hide resolved
shiny/test/fixture/_fixture.py Outdated Show resolved Hide resolved
shiny/test/playwright.py Outdated Show resolved Hide resolved
tests/playwright/README.md Outdated Show resolved Hide resolved
shiny/test/_pytest.py Outdated Show resolved Hide resolved
shiny/test/_pytest.py Outdated Show resolved Hide resolved
shiny/test/fixture/_fixture.py Outdated Show resolved Hide resolved
shiny/test/fixture/_fixture.py Outdated Show resolved Hide resolved
@schloerke schloerke enabled auto-merge May 30, 2024 19:57
@schloerke schloerke added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@karangattu karangattu added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 0d1944a May 30, 2024
32 checks passed
@karangattu karangattu deleted the make-shiny-test-module branch May 30, 2024 21:10
schloerke added a commit that referenced this pull request Jun 3, 2024
* main:
  test(conftest): Refactor conftest and controls to be imported as shiny.test module (#1413)
  `make install` shouldn't assume it has `setuptools` (#1437)
schloerke added a commit that referenced this pull request Jun 3, 2024
* main: (185 commits)
  Resolve path to file when running Shiny Express apps (#1442)
  Fix changelog formatting
  test(conftest): Refactor conftest and controls to be imported as shiny.test module (#1413)
  `make install` shouldn't assume it has `setuptools` (#1437)
  test(browsers): Unskip webkit tests (#1431)
  chore: update shiny-vscode extension ID (#1434)
  Add setuptools as an install requirement in Python 3.12 and above (#1435)
  Bump version to 0.10.2.9000
  v0.10.2 release candidate
  Use `output_code()` and `render.code()` (#1421)
  Fix: spinners only show for a split second (#1429)
  Bump version to 0.10.1.9000
  Bump version to 0.10.1
  Update CHANGELOG.md (#1419)
  Update cpu info example
  bug(CI): Only update the shiny submodule when making the dev docs (#1417)
  Update shiny CSS (#1415)
  Bump version to 0.10.0.9000 for development
  Bump version to 0.10.0
  Update shiny JS/CSS assets (#1406)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants