make install shouldn't assume it has setuptools
#1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
changed the title
make install shouldn't assume it has setuptools
schloerke
added a commit
that referenced
this pull request
Jun 3, 2024
* main: (185 commits) Resolve path to file when running Shiny Express apps (#1442) Fix changelog formatting test(conftest): Refactor conftest and controls to be imported as shiny.test module (#1413) `make install` shouldn't assume it has `setuptools` (#1437) test(browsers): Unskip webkit tests (#1431) chore: update shiny-vscode extension ID (#1434) Add setuptools as an install requirement in Python 3.12 and above (#1435) Bump version to 0.10.2.9000 v0.10.2 release candidate Use `output_code()` and `render.code()` (#1421) Fix: spinners only show for a split second (#1429) Bump version to 0.10.1.9000 Bump version to 0.10.1 Update CHANGELOG.md (#1419) Update cpu info example bug(CI): Only update the shiny submodule when making the dev docs (#1417) Update shiny CSS (#1415) Bump version to 0.10.0.9000 for development Bump version to 0.10.0 Update shiny JS/CSS assets (#1406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make dist(which is required formake install) currently assumes it has setuptools, but that is no longer the case with Python 3.12.Related #1435