Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pyright): Pin pyright version to 1.1.369 to avoid CI failures #1493

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore(pyright): Pin pyright version to 1.1.369 to avoid CI failures #1493

merged 1 commit into from
Jul 3, 2024

Conversation

schloerke
Copy link
Collaborator

Current failing output when using pyright 1.1.370:

/shiny/render/transformer/_transformer.py
  /shiny/render/transformer/_transformer.py:552:24 - error: "__getitem__" method not defined on type "UnionType" (reportIndexIssue)
  /shiny/render/transformer/_transformer.py:556:13 - error: Expected parameter type list or "..."
/shiny/ui/_layout_columns.py
  /shiny/ui/_layout_columns.py:279:41 - error: Argument type is unknown
    Argument corresponds to parameter "x" in function "maybe_fr_unit" (reportUnknownArgumentType)
  /shiny/ui/_layout_columns.py:279:48 - error: Type of "h" is unknown (reportUnknownVariableType)
  /shiny/ui/_layout_columns.py:279:53 - error: "int" is not iterable
    "__iter__" method not defined (reportGeneralTypeIssues)
  /shiny/ui/_layout_columns.py:279:53 - error: "float" is not iterable
    "__iter__" method not defined (reportGeneralTypeIssues)

@schloerke schloerke changed the title chore(pyright): Pin pyright version to avoid CI failures chore(pyright): Pin pyright version to 1.1.369 to avoid CI failures Jul 3, 2024
@schloerke schloerke enabled auto-merge July 3, 2024 16:03
@schloerke schloerke added this pull request to the merge queue Jul 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2024
@gadenbuie gadenbuie added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit bdf9718 Jul 3, 2024
31 checks passed
@gadenbuie gadenbuie deleted the pyright_updates branch July 3, 2024 16:48
schloerke added a commit to machow/py-shiny that referenced this pull request Jul 5, 2024
@schloerke
Merge branch 'main' into machow-feat-data-grid-polars
a99948d 
* main:
  test(controllers): Refactor column sort and filter methods for Dataframe class (posit-dev#1496)
  Follow up to posit-dev#1453: allow user roles when normalizing a dictionary (posit-dev#1495)
  fix(layout_columns): Fix coercion of scalar row height to list for python <= 3.9 (posit-dev#1494)
  Add `shiny.ui.Chat` (posit-dev#1453)
  docs(Theme): Fix example and clarify usage (posit-dev#1491)
  chore(pyright): Pin pyright version to `1.1.369` to avoid CI failures (posit-dev#1493)
  tests(dataframe): Add additional tests for dataframe (posit-dev#1487)
  bug(data frame): Export `render.StyleInfo` (posit-dev#1488)
schloerke added a commit that referenced this pull request Jul 9, 2024
@schloerke
Merge branch 'main' into df-ts-updates
9446039 
* main:
  feat(data frame): Support `polars` (#1474)
  api(playwright): Code review of complete playwright API (#1501)
  fix: Move `www/shared/py-shiny` to `www/py-shiny` (#1499)
  test(controllers): Refactor column sort and filter methods for Dataframe class (#1496)
  Follow up to #1453: allow user roles when normalizing a dictionary (#1495)
  fix(layout_columns): Fix coercion of scalar row height to list for python <= 3.9 (#1494)
  Add `shiny.ui.Chat` (#1453)
  docs(Theme): Fix example and clarify usage (#1491)
  chore(pyright): Pin pyright version to `1.1.369` to avoid CI failures (#1493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schloerke @gadenbuie