fix(layout_columns): Fix coercion of scalar row height to list for python <= 3.9 #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
approved these changes
Jul 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Jul 5, 2024
* main: test(controllers): Refactor column sort and filter methods for Dataframe class (posit-dev#1496) Follow up to posit-dev#1453: allow user roles when normalizing a dictionary (posit-dev#1495) fix(layout_columns): Fix coercion of scalar row height to list for python <= 3.9 (posit-dev#1494) Add `shiny.ui.Chat` (posit-dev#1453) docs(Theme): Fix example and clarify usage (posit-dev#1491) chore(pyright): Pin pyright version to `1.1.369` to avoid CI failures (posit-dev#1493) tests(dataframe): Add additional tests for dataframe (posit-dev#1487) bug(data frame): Export `render.StyleInfo` (posit-dev#1488)
schloerke
added a commit
that referenced
this pull request
Jul 9, 2024
* main: feat(data frame): Support `polars` (#1474) api(playwright): Code review of complete playwright API (#1501) fix: Move `www/shared/py-shiny` to `www/py-shiny` (#1499) test(controllers): Refactor column sort and filter methods for Dataframe class (#1496) Follow up to #1453: allow user roles when normalizing a dictionary (#1495) fix(layout_columns): Fix coercion of scalar row height to list for python <= 3.9 (#1494) Add `shiny.ui.Chat` (#1453) docs(Theme): Fix example and clarify usage (#1491) chore(pyright): Pin pyright version to `1.1.369` to avoid CI failures (#1493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python <= 3.9, the following code throws an error
We have a variant of this with
CssUnit = int | float | strinui.layout_columns(). This is fixed by usingisinstance_cssunit(), an existing helper function created just for this scenario.