Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow page_navbar to accept HTML dependencies #455

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Allow page_navbar to accept HTML dependencies #455

merged 2 commits into from
Apr 19, 2023

Conversation

wch
Copy link
Collaborator

@wch wch commented Apr 18, 2023

Previously, this would raise an error, because page_navbar expected only NavSetArg objects, but shinyswatch.theme.darkly() is a list of HTML Dependencies.

ui.page_navbar(
    shinyswatch.theme.darkly(),
    ui.nav( ... ),
)

This PR allows it to accept MetadataNode objects and lists/tuples of them.

@wch wch requested a review from jcheng5 April 18, 2023 22:17
@wch wch merged commit 7c02ee3 into main Apr 19, 2023
@wch wch deleted the nav-htmldeps branch April 19, 2023 01:42
@wch wch mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wch