Update types to allow navset_* functions to accept MetadataNode args
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that I look at it more closely, perhaps these functions should also accept Lines 1152 to 1153 in aba9459 |
cpsievert
approved these changes
Feb 1, 2024
wch
force-pushed
the
navs-metadatanode
branch
from
8976476
to
1fa455b
Compare
schloerke
added a commit
that referenced
this pull request
Feb 13, 2024
* main: Bump version to 0.7.1.9000 Fix input_task_button for modules (#1108) Bump version to 0.7.1 Test input task button and extended task decorator (#1099) Add remaining examples for express API reference (#1093) test: Add `make playwright-debug` to help debug playwright tests (#1097) Make input_selectize work correctly within a module (#1091) Update types to allow `navset_*` functions to accept `MetadataNode` args (#1094) Update changelog Update express.ui.hold() to accept any type of object (#1089)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that many of the
navset_*functions did not acceptMetadataNodearguments, but they should, in case someone wants to pass inHTMLDependencyobjects.For reference, the ability to accept
MetadataNodeargs was added to manynavset_*functions in #455, but some newernavset_*components did not have this typing.