Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom component template updates #874

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Custom component template updates #874

merged 6 commits into from
Dec 13, 2023

Conversation

nstrayer
Copy link
Collaborator

@nstrayer nstrayer commented Dec 7, 2023

Cleans up and updates the code for the custom component templates.

Changes:

  • Simplify typescript code so it uses less typescript syntax (but still retains full type-checking). This will make it easier to understand for non-typescript-fluent readers
  • Update helpers packages to use the new @posit-dev/shiny-bindings-{core/react} packages
  • Fix incorrect paths in the typescript config files and comments in the output bindings left over from older versions of templates.

@nstrayer nstrayer mentioned this pull request Dec 7, 2023
Merged
gshotwell
gshotwell approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@gshotwell gshotwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I tested the three templates and they all work well and build quite fast. I'm not sure if we want another reviewer for some of the JavaScript changes, but they LGTM as far as that goes.

@nstrayer nstrayer requested review from wch and jcheng5 December 12, 2023 21:29
@nstrayer
Copy link
Collaborator Author

@wch and @jcheng5 , requested review is mostly a rubber stamp request. This is a pretty minor PR but wanted to make sure I didnt merge something to main without a proper heads-up.

@wch wch merged commit 7602eb6 into main Dec 13, 2023
26 checks passed
@wch wch deleted the js-pkg-template-updates branch December 13, 2023 16:13
schloerke added a commit that referenced this pull request Dec 18, 2023
@schloerke
Merge branch 'main' into garrettgman/main
6a48c66 
* main: (24 commits)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  Update VS Code settings file
  Express: change default page function to page_fixed (#892)
  Better messages for `AttributeError` in Shiny Express (#888)
  Fix 0.6.0 release date
  Fix failing express tests (#887)
  Explain why function is called twice
  ...
schloerke added a commit that referenced this pull request Dec 19, 2023
@schloerke
Merge branch 'main' into drop_fn_session_param
65829a3 
* main: (76 commits)
  Add shiny/templates to MANIFEST.in files (#926)
  docs: Function Reference Proofreads (#919)
  Fix failing deploy tests (#925)
  Add GitHub sources to shiny create
  Make changelog styling more consistent
  Function reference edits (#857)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  ...
schloerke added a commit that referenced this pull request Dec 19, 2023
@schloerke
Merge branch 'main' into fn_signatures_for_docs
aecc5d8 
* main: (36 commits)
  Add shiny/templates to MANIFEST.in files (#926)
  docs: Function Reference Proofreads (#919)
  Fix failing deploy tests (#925)
  Add GitHub sources to shiny create
  Make changelog styling more consistent
  Function reference edits (#857)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshotwell gshotwell gshotwell approved these changes

@wch wch Awaiting requested review from wch

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nstrayer @gshotwell @wch