Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout_columns): Add missing bslib-mb-spacing class #906

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(layout_columns): Add missing bslib-mb-spacing class #906

merged 1 commit into from
Dec 13, 2023

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Dec 13, 2023 •
edited
Loading

Adds the .bslib-mb-spacing class to the bslib-layout-columns component to ensure that it receives bottom margin outside of gap-driven spacing contexts.

Example App 
from shiny import App, render, ui

app_ui = ui.page_navbar(
    ui.nav(
        "Page 1",
        ui.layout_columns(
            ui.fill.as_fill_item(ui.div({"class": "bg-primary ex-box"})),
            ui.fill.as_fill_item(ui.div({"class": "bg-secondary ex-box"})),
        ),
        ui.layout_columns(
            ui.fill.as_fill_item(ui.div({"class": "bg-warning ex-box"})),
            ui.fill.as_fill_item(ui.div({"class": "bg-danger ex-box"})),
        ),
        ui.tags.style(".ex-box { min-height: 100px !important; }"),
    ),
    fillable=False,
)


def server(input, output, session):
    ...


app = App(app_ui, server)

@gadenbuie gadenbuie merged commit 0319575 into main Dec 13, 2023
26 checks passed
@gadenbuie gadenbuie deleted the fix/layout-columns-mb-spacing branch December 13, 2023 17:11
schloerke added a commit that referenced this pull request Dec 18, 2023
@schloerke
Merge branch 'main' into garrettgman/main
6a48c66 
* main: (24 commits)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  Update VS Code settings file
  Express: change default page function to page_fixed (#892)
  Better messages for `AttributeError` in Shiny Express (#888)
  Fix 0.6.0 release date
  Fix failing express tests (#887)
  Explain why function is called twice
  ...
schloerke added a commit that referenced this pull request Dec 19, 2023
@schloerke
Merge branch 'main' into drop_fn_session_param
65829a3 
* main: (76 commits)
  Add shiny/templates to MANIFEST.in files (#926)
  docs: Function Reference Proofreads (#919)
  Fix failing deploy tests (#925)
  Add GitHub sources to shiny create
  Make changelog styling more consistent
  Function reference edits (#857)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  ...
schloerke added a commit that referenced this pull request Dec 19, 2023
@schloerke
Merge branch 'main' into fn_signatures_for_docs
aecc5d8 
* main: (36 commits)
  Add shiny/templates to MANIFEST.in files (#926)
  docs: Function Reference Proofreads (#919)
  Fix failing deploy tests (#925)
  Add GitHub sources to shiny create
  Make changelog styling more consistent
  Function reference edits (#857)
  docs: Use definition lists for parameter descriptions to enable full markdown support (#901)
  docs(layout_columns): Add example app (#903)
  fix(layout_columns): Remove use of enum for breakpoints (#912)
  Express: don't automatically put strings in a `<pre>` block (#905)
  Deprecate `nav()` in favor of `nav_panel()` (#876)
  chore: Remove unused import
  refactor(layout_column_wrap): Use helper for wrapping children (#910)
  fix(layout_columns): Don't apply fillable class to layout container (#909)
  Add output to React template (#908)
  fix(layout_columns): Add missing `bslib-mb-spacing` class (#906)
  Custom component template updates (#874)
  fix(layout_columns): If the breakpoint name is an enum, need to collect the value (#902)
  chore: exclude `_dev/` folder (#897)
  feat: Add `ui.layout_columns()` (#856)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gadenbuie @cpsievert