fix: unescape in URLs which are stored for tracking

closes #2568 closes #907 closes #115
postalserver · Mar 4, 2024 · 1da1182 · 1da1182
1 parent 658aa71
commit 1da1182
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/postal/message_parser.rb b/lib/postal/message_parser.rb
@@ -118,7 +118,8 @@ def insert_links(part, type = nil)
         part.gsub!(/href=(['"])(#{URL_REGEX})['"]/) do
           if track_domain?($~[:domain])
             @tracked_links += 1
-            token = @message.create_link($~[:url])
+            url = CGI.unescapeHTML($~[:url])
+            token = @message.create_link(url)
             "href='#{domain}/#{@message.server.token}/#{token}'"
           else
             ::Regexp.last_match(0)

diff --git a/script/send_html_email.rb b/script/send_html_email.rb
@@ -36,7 +36,7 @@
     <p>Hello there</p>
     <p>This is an example email. It doesn't do all that much.</p>
     <p>Some other characters: őúéáűí</p>
-    <p>There is a <a href='https://postalserver.io/test-plain-text-link?foo=bar&baz=qux'>link here</a> though...</p>
+    <p>There is a <a href='https://postalserver.io/test-plain-text-link?foo=bar&amp;baz=qux'>link here</a> though...</p>
   BODY
 end