fix(smtp-server): add additional information to cram-md5 log entries

postalserver · Mar 12, 2024 · 9982bb8 · 9982bb8
1 parent 5ed94f6
commit 9982bb8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/lib/smtp_server/client.rb b/app/lib/smtp_server/client.rb
@@ -252,7 +252,7 @@ def auth_cram_md5(data)
         org_permlink, server_permalink = username.split(/[\/_]/, 2)
         server = ::Server.includes(:organization).where(organizations: { permalink: org_permlink }, permalink: server_permalink).first
         if server.nil?
-          logger&.warn "Authentication failure for #{@ip_address}"
+          logger&.warn "Authentication failure for #{@ip_address} (no server found matching #{username})"
           increment_error_count("invalid-credentials")
           next "535 Denied"
         end
@@ -264,12 +264,13 @@ def auth_cram_md5(data)
 
           @credential = credential
           @credential.use
+          logger&.debug "Authenticated with with credential #{credential.id}"
           grant = "235 Granted for #{credential.server.organization.permalink}/#{credential.server.permalink}"
           break
         end
 
         if grant.nil?
-          logger&.warn "Authentication failure for #{@ip_address}"
+          logger&.warn "Authentication failure for #{@ip_address} (invalid credential)"
           increment_error_count("invalid-credentials")
           next "535 Denied"
         end