New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoprefixer is removing my trailing semicolons (a remaining rework issue?) #348
Comments
@AndyBean Autoprefixer has no connection with Rework for a year ;). Autoprefixer is based on PostCSS. Instead of Rework, PostCSS try to save user code style (indents, trailing semicolon). But maybe there is a regression (we rewrite a lot of parts in PostCSS 3.0 to have the fastest CSS parser). Can you write some small input with trailing semicolon and output from Autoprefixer without it? |
Hi. I'm also troubled by this removing semicolons issue.
after autoprefixer, the code becomes
|
@kyaido thanks for example. Now I know, that this problem is with last comment. I create issue in PostCSS: postcss/postcss#136 |
Thanks. |
Fixed in PostCSS 3.0.6. |
Though not technically incorrect, it is a recommended syntax by Google et al to leave the trailing semicolon. I saw on this thread that autoprefixer is built on top of rework, which was was updated over a year ago to return the semicolon; perhaps that update never happened.
It is not a huge deal, both with semicolon and without are considered valid but it is common for application tests to interpret the lack of one as an error, and it annoys my obsessive compulsive self. Should I more appropriately bother the Rework group about this?
-Andrew
The text was updated successfully, but these errors were encountered: