Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for outdated gradient syntax only inside radial-gradient block #1017

Merged
merged 2 commits into from Apr 11, 2018
Merged

Look for outdated gradient syntax only inside radial-gradient block #1017

merged 2 commits into from Apr 11, 2018

Conversation

kotfire
Copy link
Contributor

@kotfire kotfire commented Apr 11, 2018

Fixes #1015

@ai ai merged commit c860ba6 into postcss:master Apr 11, 2018
@ai
Copy link
Member

ai commented Apr 11, 2018

Thanks! I will release it with #1018

@radium-v
Copy link

Does this account for multiple background images in a shorthand?

a {
	background: linear-gradient(#F0F, #000), radial-gradient(0 0, cover, #FFF, transparent) 0 0 / cover no-repeat #F0F;
}

@ai
Copy link
Member

ai commented Apr 11, 2018

@radium-v can you try? Just clone repo and add the test (also send PR with this test).

I am going to speak on meetup. Don't have time today.

@radium-v
Copy link

Yes, I want to address this issue and dive deeper into it, I'm just waiting for some free time this weekend ;)

@ai
Copy link
Member

ai commented Apr 12, 2018

@radium-v I tested. Everything is fine 54fa0ac

@renovate renovate bot mentioned this pull request Apr 16, 2018
Merged
@ai
Copy link
Member

ai commented Apr 16, 2018

Released in 8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kotfire @ai @radium-v