Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FAQ section for IE grid support caveats #1075

Merged
merged 2 commits into from Jul 2, 2018
Merged

Conversation

CyberAP
Copy link
Contributor

@CyberAP CyberAP commented Jul 2, 2018

See: #1074

@ai
Copy link
Member

ai commented Jul 2, 2018

Good idea. Let's just add free code examples and link to that CSS Trick article.

@ai ai merged commit 900a835 into postcss:master Jul 2, 2018
@CyberAP CyberAP deleted the patch-1 branch July 2, 2018 21:56
@ai
Copy link
Member

ai commented Jul 2, 2018

I improve this FAQ section 83cbac7

WHat do you think?

@CyberAP
Copy link
Contributor Author

CyberAP commented Jul 3, 2018

Seems reasonable. But I'd still add an example with no grid-template* or grid-area set, using only manual grid item assignment. Like this:

.grid
{
  display: grid;
}

.grid > :nth-child(1)
{
  grid-column: 1;
  grid-row: 1;
}

.grid > :nth-child(2)
{
  grid-area: 1 / 2; /* Shorthand for grid-row and grid-column */
}

@ai
Copy link
Member

ai commented Jul 3, 2018

Why do you like to avoid grid-template? It is more readable in my opinion.

@CyberAP
Copy link
Contributor Author

CyberAP commented Jul 3, 2018

To show that it is not required here and it can work out of the box without it. The only thing that has to be done is grid item assignment.

@ai
Copy link
Member

ai commented Jul 3, 2018

In the new section, I cover a little more than just Grid with a missed position. Also, I am not sure that :nth-child(1) and grid-column/row is the best practice to promote it. It is better to promote BEM selectors and readable position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants