Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[grid-area] fix sequence of breakpoints #1087

Merged
merged 5 commits into from Aug 3, 2018
Merged

[grid-area] fix sequence of breakpoints #1087

merged 5 commits into from Aug 3, 2018

Conversation

bogdan0083
Copy link
Contributor

This PR fixes #1085

The logic of this fix is simple:

  • As the rules being packed into a single the media rule (1), check the closest rule down below. If it's a media rule (2) and it contains the same selectors - insert (1) after (2).

You can check out the test cases to review is everything ok with the order.

Thanks! :)

@bogdan0083 bogdan0083 mentioned this pull request Aug 3, 2018
Closed
@ai
Copy link
Member

ai commented Aug 3, 2018

@Dan503 can I ask you to review it?

@Dan503
Copy link
Contributor

Dan503 commented Aug 3, 2018

The media queries look to me like they are behaving as they are supposed to in the test case file.

I'm happy :)

@ai ai merged commit 309e14c into postcss:master Aug 3, 2018
@ai
Copy link
Member

ai commented Aug 3, 2018

I will released it on next caniuse-db release to fix also ai/autoprefixer-rails#139

@ai
Copy link
Member

ai commented Aug 13, 2018

Released in 9.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dan503 Dan503 Dan503 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Grid - Sequence of Breakpoints
3 participants
@bogdan0083 @ai @Dan503