Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runner guidelines #21

Closed
w0rm opened this issue Apr 1, 2015 · 11 comments · Fixed by #29
Closed

Support runner guidelines #21

w0rm opened this issue Apr 1, 2015 · 11 comments · Fixed by #29

Comments

@w0rm
Copy link
Member

w0rm commented Apr 1, 2015

PostCSS Runner Guidelines

w0rm added a commit that referenced this issue Apr 1, 2015
@ai
Copy link
Member

ai commented Apr 2, 2015

Don’t forget to uses warnings API

@w0rm
Copy link
Member Author

w0rm commented Apr 3, 2015

Yeah, I'm now trying several approaches of how this may be tested, I don't like the current one and I think of a better approach to mock postcss module completely in order to spy on the passed options.

@w0rm
Copy link
Member Author

w0rm commented Apr 11, 2015

@ai I took a look into postcss-log-warnings and postcss-messages plugins, and I think its better to just use them instead of integrating this into gulp-postcss, what do you think?

w0rm added a commit that referenced this issue Apr 11, 2015
w0rm added a commit that referenced this issue Apr 11, 2015
w0rm added a commit that referenced this issue Apr 11, 2015
w0rm added a commit that referenced this issue Apr 12, 2015
@ai
Copy link
Member

ai commented Apr 12, 2015

Yeap, I think so. But does Gulp Guidelines allow it? As I understand you must to write gulp-postcss and uses common syntax.

@w0rm
Copy link
Member Author

w0rm commented Apr 12, 2015

There is gulp-utils package that has log method, I decided to use it to output warnings. I'm not sure about the formatting, I simply joined warnings with new line symbol for now.

@ai
Copy link
Member

ai commented Apr 12, 2015

@w0rm it is fine for now. postcss-messages works same.

@w0rm
Copy link
Member Author

w0rm commented Apr 12, 2015

@ai ok, I will publish a new version that follows runner guidelines

w0rm added a commit that referenced this issue Apr 12, 2015
@ai
Copy link
Member

ai commented Apr 12, 2015

Awesome. Ping me when you finish it. I post a trolling tweet that Gulp is better :-)

@w0rm
Copy link
Member Author

w0rm commented Apr 12, 2015

@ai 5.1.0 published on npm

@ai
Copy link
Member

ai commented Apr 12, 2015

Holywar tweet was sent :D

@w0rm
Copy link
Member Author

w0rm commented Apr 12, 2015

@ai cool, thanks for the mention!

gucong3000 added a commit to gucong3000/gulp-postcss that referenced this issue Nov 15, 2017
* Update dependencies

* Update config of travis-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants