-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support runner guidelines #21
Comments
Don’t forget to uses warnings API |
Yeah, I'm now trying several approaches of how this may be tested, I don't like the current one and I think of a better approach to mock postcss module completely in order to spy on the passed options. |
@ai I took a look into postcss-log-warnings and postcss-messages plugins, and I think its better to just use them instead of integrating this into gulp-postcss, what do you think? |
Yeap, I think so. But does Gulp Guidelines allow it? As I understand you must to write |
There is gulp-utils package that has log method, I decided to use it to output warnings. I'm not sure about the formatting, I simply joined warnings with new line symbol for now. |
@w0rm it is fine for now. |
@ai ok, I will publish a new version that follows runner guidelines |
Awesome. Ping me when you finish it. I post a trolling tweet that Gulp is better :-) |
@ai 5.1.0 published on npm |
Holywar tweet was sent :D |
@ai cool, thanks for the mention! |
* Update dependencies * Update config of travis-ci
PostCSS Runner Guidelines
The text was updated successfully, but these errors were encountered: