Set from option for stdin to process.cwd() + 'stdin.css' #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
approved these changes
Apr 1, 2017
index.js
Outdated
| @@ -279,7 +279,7 @@ function css (css, file) { | |||
| if (file === 'stdin' && output) file = output | |||
|
|
|||
| // TODO: Unit test this | |||
| if (file !== 'stdin') options.from = file | |||
| options.from = file === 'stdin' ? path.join(process.cwd(), 'stdin.css') : file | |||
There was a problem hiding this comment.
The dummy file stdin.css is a requirement or would process.cwd() just be fine also ? Sourcemaps won't work either way
There was a problem hiding this comment.
The issue at hand is that some plugins do path.dirname(options.from) to get the containing folder as the basis for resolving other files relative to the CSS. So yes, we need a dummy filename. Perhaps it should be stdin instead of stdin.css to avoid confusion (especially with SugarSS)?
|
LGTM |
|
@ai @michael-ciniawsky Thoughts on using |
|
Yeap, it will be better |
Should fix #114; will revert if this causes other issues.
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #114; will revert if this causes other issues.
@michael-ciniawsky @ai Please review