Add preferred-color-scheme: light support
#23
Conversation
README.md
Outdated
| @@ -28,6 +28,15 @@ from media query to special class. | |||
| background: black | |||
| } | |||
| } | |||
|
|
|||
| @media (prefers-color-scheme: light) { | |||
There was a problem hiding this comment.
Let’s keep example simple.
But we can mentioned somewhere that we support both light and dark schemes.
There was a problem hiding this comment.
You are right, it looks redundant. I think the phrase plugin to make switcher to force dark or light theme by copying styles from media query to special class has already described that.
Removed the example for the light scheme.
| @@ -17,6 +18,12 @@ test('replaces selectors', () => { | |||
| html, | |||
| :root, | |||
| a { } | |||
| } | |||
| @media (prefers-color-scheme:light) { | |||
There was a problem hiding this comment.
Can you add the light tests to a separated test (maybe one extra test for both cases together)?
Our tests already too long, it will simplify tests.
There was a problem hiding this comment.
Separated tests for the light scheme to individual tests and added one extra test for both schemes.
|
A few small fixes for docs and tests, and we are ready to merge. The plugin changes looks good. I already mark task on Cult of Martians as solved by you. Do you have a twitter account to mentioned you? |
Yes, I have. I use it for reading only but you can certainly mention me if you want :) @astashkinana |
|
Thanks. This feature was released at 1.0. |
Added
preferred-color-scheme: lightsupport#7