Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a feature to preserve or not the original code #34

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

aletorrado
Copy link
Contributor

Hi, I added a preserve parameter that defaults to true, consistent with how other common postcss plugins handles this matter (more on this here).

Thanks!

@ai
Copy link
Member

ai commented Apr 21, 2024

Let's use a different name for parameter. classOnly or something like this, to highlight that it is another mode.

@aletorrado
Copy link
Contributor Author

Sure. I used onlySelectors as not just classes may be used, but any other selector would work.

@ai
Copy link
Member

ai commented Apr 22, 2024

You need to add more tests to keep 100% lines coverage.

And let’s name option as removeMedia.

@aletorrado
Copy link
Contributor Author

Sure. I've just added those.

@ai ai merged commit d378b04 into postcss:main Apr 22, 2024
3 checks passed
@ai
Copy link
Member

ai commented Apr 22, 2024

Thanks. Released in 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants