Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom mode usage possible #32

Merged
merged 4 commits into from Jun 16, 2015
Merged

Make custom mode usage possible #32

merged 4 commits into from Jun 16, 2015

Conversation

cakeinpanic
Copy link
Contributor

Hello!
I'm trying to use your module with custom url() function, but I figured out you don't pass to, from and some other params to custom function
I fixed it.

@MoOx
Copy link
Contributor

MoOx commented Jun 16, 2015

By bringing this change, you are breaking the current api. I would go for addding new parameters at the end, or via a new object at the end.
Also, to please run "npm test" before pushing your changes to be sure you respect coding convention & that existing tests are not broken.
And maybe you should add a test somewhere to prove that what your bring worth it :) (+ minimal doc in README)

@cakeinpanic
Copy link
Contributor Author

I wanted to use this feature, but i couldn't because of this issue – this is the best worthiness prove)
I fixed tests and also added backward compatibility within my last commit, so now it's not breaking changes anymore and can be merged)

@MoOx
Copy link
Contributor

MoOx commented Jun 16, 2015

Great job !

MoOx added a commit that referenced this pull request Jun 16, 2015
Make custom mode usage possible
@MoOx MoOx merged commit 93df48c into postcss:master Jun 16, 2015
@MoOx
Copy link
Contributor

MoOx commented Jun 16, 2015

Released as 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants