New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to postcss-assets-rebase #442
Conversation
There's no link to the plugin? |
@ben-eb and order is wrong :). I wil fix it. |
Also, it's seems to be a duplicate. postcss-url already does that (and many more). |
@MoOx I am OK with high specific tools for one purpose. Sometimes it is difficult to understand how to use postcss-url in this way. And anyway you will have a some unshared code in postcss-url callbacks. |
postcss-url is a complete solution to handle assets. It can inline and fallback to rebase + copy for example. |
@MoOx but postcss-url can’t do postcss-assets-rebase behaviour without the line of code? I mean, that anyway user will be forced to write few lines for callback. And of course he/she want to share this code. This is why some specific solution is OK. |
No need for a callback. Where did you see that? Callback is just another way to handle custom adjustment. https://github.com/postcss/postcss-url#usage |
@MoOx hm, my mistake. So @cakeinpanic what do you think? |
@MoOx I've tried yo use By now, there are two options different from |
@MoOx if you want, we can try to merge our plugins, no problem. |
Fact: I only use url: rebase method (for imports), since my assets are handled by webpack. |
Yeap, I am thinking right not to remove this plugin. |
hi @cakeinpanic as you said I did a rewrite of the copy method, here you can see the repo where i'm testing it: https://github.com/tinchoz49/test-postcss-copy |
I've checked your test repo, thank you, @tinchoz49
In
For now I can say that our plugin fits better for postprocessing files generated by stylus(or LESS, or another preprocessor) @ai what do you think, is it still count as duplicate? |
Yeap, the problem with dublicate is not that it is equal, but in splitting forces. It is always better to put forces to one project, than support two. But I am not against adding it to list. |
No description provided.