Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Fix carrier return parsing to v7 #1890

Closed
wants to merge 1 commit into from

Conversation

mhassan1
Copy link

This PR backports 58cc860, which fixes CVE-2023-44270, to v7.

@ai
Copy link
Member

ai commented Oct 10, 2023

Last time I spend half of the day backporting security fix.

It is time to move to 8.x or donate enough and ask me as a project sponsor.

@mhassan1
Copy link
Author

Unfortunately, we have 80 dependencies in our lockfile that depend on postcss@7, and I assume others are in the same boat.

I see 30 million downloads of v7 in the past week, which is almost half the total downloads, so I assume others will appreciate the backport.

@ai
Copy link
Member

ai commented Oct 10, 2023

Maybe lack of security update will be the push for the community? Right now I need to spend more resources supporting very old plugins.

@mhassan1
Copy link
Author

mhassan1 commented Oct 10, 2023

I don't think it would be reasonable to backport to v6 or v5, even though they still get a few million downloads per week; however, v7 seems to be heavily used and may not be old enough to be considered very old just yet.

@ai
Copy link
Member

ai commented Oct 10, 2023

PostCSS 7 is 3 years old.

Even Node.js doesn’t suggest so long support.

@Semigradsky
Copy link
Member

Semigradsky commented Oct 10, 2023

80 dependencies in our lockfile that depend on postcss@7

smth like old version of nano or postcss-preset-env?

@mhassan1
Copy link
Author

80 dependencies in our lockfile that depend on postcss@7

smth like old version of nano or postcss-preset-env?

If I bump a bunch of packages, it reduces the number of v7 resolutions significantly; however, there are some dependency paths that still include v7:

  • @storybook/builder-webpack4
  • react-scripts > resolve-url-loader@4

@Semigradsky
Copy link
Member

Oh, CRA is a pain... Storybook can be updated, but not so easy with CRA

@mhassan1
Copy link
Author

@ai Given that Storybook and CRA still depend on v7, do we feel any different about this backport?

@ai
Copy link
Member

ai commented Oct 13, 2023

We should spend this energy to migrate Storybook rather than backport fixes.

Storybook migration will reduce maintance costs for me. Backporting fix will force me to backport fixes again and again in the future.

Only big sponsor request of backport will change my mind. Open source should be fun. If it looks like job, it should be paid.

@mhassan1
Copy link
Author

Only big sponsor request of backport will change my mind. Open source should be fun. If it looks like job, it should be paid.

What does this mean, exactly? I can see if my company would make a donation for this backport, but I have no idea how or how much.

@ai
Copy link
Member

ai commented Oct 13, 2023

I can see if my company would make a donation for this backport, but I have no idea how or how much.

Any “Sponsorship …” badge from PostCSS’ OpenCollective.

@mhassan1
Copy link
Author

I am closing this, for now. We can reopen it later, if there's interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants