geohash_point_as_int: Fix undefined behaviour in shift operation #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing undefined behaviour in test_geohash_point_as_int: Running test 'test_geohash_point_as_int' in suite 'computational_geometry'.lwalgorithm.c:669:18: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Patch by Raul Marin (Carto)
|
Looks good, but may I ask on which sistem you get the runtime error ?
I'd love to see that runtime error in one of the bots we're using.
Maybe CARTO would be interested in donating a Jenkins client to add
another test environment ?
|
|
I'm running on x86_64 with sanitizer flags: It should be possible to add some flags and check them (depending on the configuration it will, or not, stop the program). Not sure if these flags are available in gcc 4.8.4 though, but I can confirm it works in gcc 7.2.0 and clang 5.0.0. |
|
Looks like we could do that trick on travis w/ the right toolchain https://docs.travis-ci.com/user/languages/c/ |
|
Yep, and/or on Jenkins,GitLab-CI,Drone
Drone builds are based on a Docker image so it should be very simple
to install what it takes to enable that. Please see
https://git.osgeo.org/gogs/postgis/postgis-docker
if you want to give it a try
|
|
Trac ticket corresponding to this PR is ? |
|
Sorry, it's here: https://trac.osgeo.org/postgis/ticket/3875 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing undefined behaviour in test_geohash_point_as_int:
0x0001 is a signed int so shifting it 31 bits is undefined. 0x00001u is unsigned so the bit shift is ok.