Fix GCC warnings #162
Closed
Fix GCC warnings #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch by Darafei Praliaskouski <me@komzpa.net> Obey const pointer in autofix logic.
pramsey
reviewed
Oct 11, 2017
liblwgeom/lwgeom_geos.c
Outdated
| { | ||
| ptarray_append_point(pa, getPoint_internal(pa, 0), LW_TRUE); | ||
| ptarray_append_point(npa, (POINT4D*)getPoint_internal(npa, 0), LW_TRUE); |
There was a problem hiding this comment.
Would you use getPoint4d_p instead? Getting addicted to pointing right into the array is a good way to start reading off the end of it.
|
Very not good, in |
|
Why all this mucking around screwing w/ const inputs in ptarray_to_GEOSLinearRing when in ptarray_to_GEOSCoordSeq you can create and return a coordseq of the desired size without mutating the input (and, btw, breaking the const contract!) |
|
Trac ticket: https://trac.osgeo.org/postgis/ticket/3900 |
|
Committed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Darafei Praliaskouski me@komzpa.net
Obey const pointer in autofix logic.