Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwprint_double: Avoid undefined behaviour with infinity #200

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion liblwgeom/lwprint.c
Expand Up @@ -488,7 +488,7 @@ int
lwprint_double(double d, int maxdd, char* buf, size_t bufsize)
{
double ad = fabs(d);
int ndd = ad < 1 ? 0 : floor(log10(ad)) + 1; /* non-decimal digits */
int ndd;
int length = 0;
if (ad <= FP_TOLERANCE)
{
Expand All @@ -497,6 +497,7 @@ lwprint_double(double d, int maxdd, char* buf, size_t bufsize)
}
if (ad < OUT_MAX_DOUBLE)
{
ndd = ad < 1 ? 0 : floor(log10(ad)) + 1; /* non-decimal digits */
if (maxdd > (OUT_MAX_DOUBLE_PRECISION - ndd)) maxdd -= ndd;
length = snprintf(buf, bufsize, "%.*f", maxdd, d);
}
Expand Down