New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to unstroke GEOMETRYCOLLECTION #209

Closed
wants to merge 3 commits into
base: svn-trunk
from

Conversation

Projects
None yet
1 participant
@Algunenano
Member

Algunenano commented Feb 16, 2018

  • Switched from clone to deep clone to avoid invalid access in the test. Since the test are free'ing the input geometry right after the stroke call the memory could (and did) become corrupt.
  • Add support to unstroke GEOMETRYCOLLECTION. Stroking was supported but not the reverse.
  • Move the unstroke tests to cu_lwstroke.c since it makes more sense to have them there.

Best reviewed per commit.

@codecov

This comment has been minimized.

codecov bot commented Feb 16, 2018

Codecov Report

Merging #209 into svn-trunk will increase coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##           svn-trunk     #209      +/-   ##
=============================================
+ Coverage      79.32%   79.33%   +<.01%     
=============================================
  Files            201      201              
  Lines          62973    63006      +33     
=============================================
+ Hits           49954    49986      +32     
- Misses         13019    13020       +1
Impacted Files Coverage Δ
liblwgeom/ptarray.c 90.26% <ø> (ø) ⬆️
liblwgeom/cunit/cu_ptarray.c 99.74% <ø> (-0.05%) ⬇️
liblwgeom/cunit/cu_lwstroke.c 97.05% <100%> (+1.7%) ⬆️
liblwgeom/lwstroke.c 85.37% <60%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d884ff8...cb28477. Read the comment docs.

@strk strk closed this in f58c204 Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment