int32_t hash #429
Closed
int32_t hash #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix for https://trac.osgeo.org/postgis/ticket/4433
Use int32_t for the hashing functions
NOTE: We should alert that any indexes using HASH(geometry) need to be rebuilt since the hashing function changed.
NOTE 2: We should consider using the extended hash (64 bit) which was introduced for PG10 (I think: 81c5e46c490e2426db243eada186995da5bb0ba7)
@pramsey Since you recently modified this code, can you have a quick look?