MultiPoint WKT writer: use parentheses in sub-members in WKT_ISO format #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is what is mandated by the spec. As put in a code comment, we should in theory also do that for SFSQL since this is what SFA 1.2.1 BNF mandates, but it looks like SFSQL means "old way", so I didn't touch that. I see SFA 1.2.1 BNF is consistent with this old draft of the SQL/MM Part 3 spec (https://web.archive.org/web/20071212154300/http://jtc1sc32.org/doc/N1101-1150/32N1107-WD13249-3--spatial.pdf) I discovered this issue when realizing that GDAL rejected strings like 'MULTIPOINT Z (1 2 4,4 5 6)' that current PostGIS exports with ST_AsText()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is what is mandated by the spec. As put in a code comment,
we should in theory also do that for SFSQL since this is what SFA 1.2.1 BNF
mandates, but it looks like SFSQL means "old way", so I didn't touch
that. I see SFA 1.2.1 BNF is consistent with this old draft
of the SQL/MM Part 3 spec
(https://web.archive.org/web/20071212154300/http://jtc1sc32.org/doc/N1101-1150/32N1107-WD13249-3--spatial.pdf)
I discovered this issue when realizing that GDAL rejected strings like
'MULTIPOINT Z (1 2 4,4 5 6)' that current PostGIS exports with
ST_AsText()