-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish the manual in HTML5 #743
Conversation
One visual difference I can see is bullets on tables of contents. These can be avoided e.g.: ul.toc li {
list-style-type: none;
} |
We look for html/docbook.xsl at configure time so if html5 is needed we'd need configure.ac to be updated to check for that too |
OK. I've put that back. |
Don't you want the chunked html to also be UTF-8 ? |
See html/style.css to tweak that |
Chunked is already UTF-8, I hesitated about adding the CSS (I have used it locally) if it only applied to the single page and not the chunked one. [1] |
May I ask you to please file a ticket for the misencoded HTML manual on https://trac.osgeo.org/postgis ? It will then be easier to schedule inclusion of your patch. |
This enables the single page manual to be encoded in UTF-8 instead of ISO-8859-1, and allows browsers to process the pages without resorting to quirks mode.
OK., created https://trac.osgeo.org/postgis/ticket/5553#ticket I've also updated the PR to included the chunked manual. |
doc/Makefile.in
Outdated
@@ -107,6 +107,7 @@ XSLTPROC_COMMONOPTS= \ | |||
--param table.borders.with.css 1 \ | |||
--stringparam chunker.output.encoding UTF-8 \ | |||
--stringparam chunker.output.indent no \ | |||
--stringparam html.ext .html \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why/where did you need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the pages are being saved with a .xhtml extension. This seemed like a good idea to minimise the change -- but looks like a problem. I hadn't tried the chunked-html-web
target, and now the <script />
tag is not being seen as closed and making the page blank - as published on https://postgis.net/docs/manual-dev/en/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes should be later on in the Docbook Specifics section.
I've added a separate commit because the first one has been reviewed - and not sure where https://postgis.net/docs/manual-dev/en/ has been published from. Ideally this new commit could be just squashed in though without any comments. |
Back to the start. Just XHTML for the single page - and accept the extra CSS in style.css? |
No, that was wrong - I hadn't updated my local environment. The internal links work fine. But... it would break any links people have created elsewhere to specific pages. |
Maybe it's best to just solve the initial problem of the single page not being UTF-8: We're a bit trapped by xsltproc only supporting XSLT 1.0 and the development of the DocBook XSL templates having moved on to XSLT 3.0. |
With ga.js being removed fd46289 the problem of a blank opening page when served as text/html has gone. |
The currently used html/docbook.xsl outputs ISO-8859-1.
Is there another way other than switching to xhtml5? But unlike chunked output (which is UTF-8) there is no param to set.