-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate sfcgal functions #760
Reinstate sfcgal functions #760
Conversation
In version 2.x of PostGIS, there was a mechanism for choosing the backend between GEOS and SFCGAL for certain operations. When adding the SFCGAL extension, the backend was removed, and some SFCGAL functions that duplicated GEOS functionality were also removed. This commit reintroduces these functions but prefixes them with CG_ to distinguish them from the "classic" GEOS functions using the prefix ST_. Often, the 2D functions will produce the same result, sometimes with small differences due to the algorithms or calculation methods used. Fixes https://trac.osgeo.org/postgis/ticket/5405
e36ffa9
to
3a8f94b
Compare
For the documentation, I added each function in a new sub-folder to make the file |
I'd rather we not break each function into a separate file. It's not like there are that many that reference_sfcgal.xml is that bloated. It would also break convention, as other extensions and even postgis proper, do not have a separate file for each function. We could have more than one sfcgal file, if you feel there are distinct themes deserving their own dedicated file. |
OK, done in a6dac83 |
@lbartoletti Now that you have commit rights, feel free to commit this yourself. Let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me
Yes, I didn't see anything in the documentation. But, is it safe to merge on github, or should I push my commits to gitea? I opened here, to check the Cirrus CI at the same time. I've seen other PRs integrated from Github, but I'm intrigued by this sentence in the documentation: |
In version 2.x of PostGIS, there was a mechanism for choosing the backend between
GEOS and SFCGAL for certain operations. When adding the SFCGAL extension, the
backend was removed, and some SFCGAL functions that duplicated GEOS functionality
were also removed. This commit reintroduces these functions but prefixes them
with CG_ to distinguish them from the "classic" GEOS functions using the prefix
ST_.
Often, the 2D functions will produce the same result, sometimes with small
differences due to the algorithms or calculation methods used.
Fixes https://trac.osgeo.org/postgis/ticket/5405